New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make primitive lookup case insensitive #213

Merged
merged 3 commits into from Aug 16, 2018

Conversation

Projects
None yet
3 participants
@kmax12
Member

kmax12 commented Aug 15, 2018

With this PR, we now handle the case where the name of the primitive isn't already all lower case

@codecov-io

This comment has been minimized.

codecov-io commented Aug 15, 2018

Codecov Report

Merging #213 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   93.46%   93.49%   +0.02%     
==========================================
  Files          71       71              
  Lines        7784     7789       +5     
==========================================
+ Hits         7275     7282       +7     
+ Misses        509      507       -2
Impacted Files Coverage Δ
featuretools/primitives/utils.py 85.36% <100%> (ø) ⬆️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 98.36% <100%> (+0.02%) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 93.18% <0%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0990175...4812f63. Read the comment docs.

@kmax12 kmax12 requested a review from rwedge Aug 16, 2018

kmax12 added some commits Aug 16, 2018

@rwedge

This comment has been minimized.

Contributor

rwedge commented Aug 16, 2018

Looks good!

@kmax12 kmax12 merged commit cca119c into master Aug 16, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Aug 20, 2018

Merged

v0.2.2 #220

@kmax12 kmax12 deleted the case-insensitive-lookup branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment