New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrapper for scikit-learn Pipelines #323
Conversation
@bukosabino thank you! looks like linting is causing tests to fail. can you run Currently, tests are failing with the following lint errors:
|
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
+ Coverage 95.25% 95.28% +0.03%
==========================================
Files 71 74 +3
Lines 7689 7787 +98
==========================================
+ Hits 7324 7420 +96
- Misses 365 367 +2
Continue to review full report at Codecov.
|
@bukosabino I think we need to support providing X as a list of cutoff times and not just instance ids. since the handling of time is one of featuretools key features. the logic would be: if it is a dataframe, pass to cutoff times argument. If it is a list or series pass to instance_ids argument. |
Looks good. Merging! |
#163