New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of fixtures in agg primitive tests #325

Merged
merged 3 commits into from Nov 26, 2018

Conversation

Projects
None yet
2 participants
@kmax12
Member

kmax12 commented Nov 21, 2018

This PR removes the usage of fixture in one of our test files. The usage of fixture didn’t simplify the code or encourage reusability, so they’ve been removed

@kmax12 kmax12 changed the title from remove fixtures to Remove usage fixtures in agg primitive tests Nov 21, 2018

@codecov

This comment has been minimized.

codecov bot commented Nov 21, 2018

Codecov Report

Merging #325 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   95.12%   95.13%   +<.01%     
==========================================
  Files          71       71              
  Lines        7714     7702      -12     
==========================================
- Hits         7338     7327      -11     
+ Misses        376      375       -1
Impacted Files Coverage Δ
...ools/tests/primitive_tests/test_direct_features.py 100% <ø> (ø)
...tools/tests/primitive_tests/test_primitive_base.py 97.36% <ø> (ø)
...s/tests/primitive_tests/test_transform_features.py 98.87% <ø> (ø)
...aturetools/tests/primitive_tests/test_agg_feats.py 99.06% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f54ac...6bc663e. Read the comment docs.

@kmax12 kmax12 changed the title from Remove usage fixtures in agg primitive tests to Remove usage fixtures of in agg primitive tests Nov 25, 2018

@kmax12 kmax12 changed the title from Remove usage fixtures of in agg primitive tests to Remove usage of fixtures in agg primitive tests Nov 25, 2018

@rwedge

rwedge approved these changes Nov 26, 2018

Looks good

@kmax12 kmax12 merged commit 5a3cf61 into master Nov 26, 2018

3 checks passed

codecov/patch 100% of diff hit (target 95.12%)
Details
codecov/project 95.13% (+<.01%) compared to 65f54ac
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Nov 29, 2018

Merged

v0.4.1 #329

@kmax12 kmax12 deleted the clean-primitive-tests branch Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment