Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cum_transform_feature Docstrings #494

Merged
merged 6 commits into from Apr 18, 2019
Merged

Conversation

glentennis
Copy link
Contributor

Rewriting docstrings in cum_transform_feature.py to include a full description and doctest.

@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #494 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #494   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         108      108           
  Lines        8862     8862           
=======================================
  Hits         8516     8516           
  Misses        346      346
Impacted Files Coverage Δ
...tools/primitives/standard/cum_transform_feature.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bfc61c...a025ae4. Read the comment docs.

@gsheni gsheni self-requested a review April 16, 2019 18:29
@gsheni gsheni assigned gsheni and unassigned gsheni Apr 16, 2019
@glentennis
Copy link
Contributor Author

@kmax12 I edited the descriptions and doctests to be more clear about the way NaN values are handled, let me know what you think!

Also, I noticed the way NaN values are handled in CumMean might not be optimal. NaN values in a window are treated as zero, so when given the list [1, None, 1], CumMean returns:

[1, nan, .66]

When perhaps we would expect it to return

[1, nan, 1]

should i open an issue to fix this?

Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsheni gsheni merged commit fd4145c into alteryx:master Apr 18, 2019
@rwedge rwedge mentioned this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants