Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sklearn version requirements #541

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

commented May 10, 2019

sklearn 0.21 doesn't support python 27 so we must adjust our version requirement

@codecov

This comment has been minimized.

Copy link

commented May 10, 2019

Codecov Report

Merging #541 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         114      114           
  Lines        9258     9258           
=======================================
  Hits         8912     8912           
  Misses        346      346

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d399898...fef0947. Read the comment docs.

@rwedge rwedge requested a review from kmax12 May 10, 2019

@kmax12

kmax12 approved these changes May 10, 2019

Copy link
Member

left a comment

LGTM

@rwedge rwedge merged commit 8f8a94f into master May 10, 2019

4 checks passed

codecov/patch Coverage not affected when comparing d399898...fef0947
Details
codecov/project 96.26% remains the same compared to d399898
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge deleted the update-sckikit-learn-req branch May 10, 2019

@rwedge rwedge referenced this pull request May 17, 2019

Merged

v0.8.0 #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.