Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: virtual-dom doesn't seem to compare two widgets for equality based on key - or at least, if one key is undefined and the other isn't they're compared as equal and the component is updated, not calling the
onadd
event.Secondly, if two components have different constructors but undefined keys, then they're considered equal. This is more of a hyperdom issue.
In any case, in this patch we compare the keys and constructors before deciding whether to update or create a component.