router history parameter?

[joshski]

master mocha tests are failing because there is no window in the new history abstraction.

A router is currently defined like this:

h('div',
   router(
      router.page('/', function () {})
   )
)

So I was wondering, since both router and router.page need access to the history abstraction, do you see it as a global thing?

This might be better:

var router = plastiq.router({ history: myHistoryApi });

...

h('div',
   router(
      router.page('/', function () {})
   )
)

wdyt?

[refractalize]

Yeah I think that's right. Though I want to have a simpler API for the common case (in browser) - not sure how we'd do both at the moment...

[joshski]

isn't that just a question of:

var router = plastiq.router;

vs...

var router = plastiq.router();

?

[joshski]

even the browser case probably wants to choose between hash or history, so perhaps:

var router = plastiq.router({ history: 'html5' });

[refractalize]

yeah, perhaps having to create a router isn't so bad, even in the common case

[refractalize]

I've done the behind the scenes work in ae58192, router is now an object. Havne't exposed it as plastiq.router yet, not can you create a new one yourself, but getting there.

[refractalize]

API is var router = plastiq.router([options]), as of 1111247