Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow event handlers to return arrays of components to refresh them #44

Merged
merged 2 commits into from Sep 17, 2015

Conversation

Anchakor
Copy link
Contributor

Allow event handlers to return arrays of components to refresh them, not the entire view.
There might be much better ways to do it, I'm not well versed in JS by any means.

@refractalize
Copy link
Member

@joshski SauceLabs seems not to be working for us, any ideas?

https://travis-ci.org/featurist/plastiq/builds/80879067#L363

How did it work before?

@refractalize
Copy link
Member

@Anchakor would you mind creating a test for this, similar to the requirebin snippet you had in the email. Take a look at this test as a guide: https://github.com/featurist/plastiq/blob/master/test/browser/plastiqSpec.js#L852-L894

@Anchakor
Copy link
Contributor Author

@refractalize I've been trying to parse the CI output (I'm used to TeamCity), what tests is it failing? Most I've seen are browsers failing to start...

@refractalize
Copy link
Member

Oh, not your fault, something seems to be different (or broken) about our saucelabs configuration. It has been working up until now. We'll fix that, but in the meantime could you write a test for your work? that way we'll know this feature will continue to work.

@Anchakor
Copy link
Contributor Author

Yeah I'll write the test, in the meantime I managed to get karma running locally.

@Anchakor
Copy link
Contributor Author

I added the test, seemed to have worked fine locally.

@refractalize refractalize merged commit a672e46 into featurist:master Sep 17, 2015
@refractalize
Copy link
Member

Thanks @Anchakor, in v1.23.0

@Anchakor
Copy link
Contributor Author

@refractalize No problem, thanks for the framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants