Vdom outside render loop #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds great! |
|
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed an issue that has been with hyperdom/plastiq since the beginning. DOM event handlers have always needed to refresh the view after they run, and to do this they needed to have been recognised during the render loop. A consequence of this was that defining VDOM with event handlers outside of the render loop meant that those event handlers didn't refresh the view, which is annoying and a bit confusing.
This PR fixes that issue. Now, VDOM with event handlers can be prepared beforehand, outside the render loop, statically, and be used in various places in the VDOM. This allows VDOM to be defined once and reused - which can dramatically improve performance.
CC @dereke