Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document type filter and MUR & ADR UI changes #6249

Closed
wants to merge 19 commits into from

Conversation

patphongs
Copy link
Member

@patphongs patphongs commented May 8, 2024

Summary (required)

(Include a summary of proposed changes and connect issue below)

Required reviewers

(Include who is required to review prior to merge. For example: One designer and two front end developer reviews are required prior to merge)

Impacted areas of the application

General components of the application that this PR will affect:

Screenshots

(Include a screenshot of the new/updated features in context (“in the wild”). If it is an interface change, include both before and after screenshots)

Related PRs

Related PRs against other branches:

branch PR
fix/other_pr link
feature/other_pr link

How to test

(Include any information that may be helpful to the reviewer(s). This might include links to sample pages to test or any local environmental setup that is unusual such as environment variable (never credentials), API version to point to, etc)

System architecture updates (if applicable)

(If this pull request changes our current system diagram, include a description of those changes here and create a new ticket to update the system diagram)

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 77.84%. Comparing base (cf19bed) to head (af07dec).
Report is 2 commits behind head on develop.

Current head af07dec differs from pull request most recent head 3999cbd

Please upload reports for the commit 3999cbd to get more accurate results.

Files Patch % Lines
fec/legal/views.py 0.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6249      +/-   ##
===========================================
- Coverage    78.00%   77.84%   -0.16%     
===========================================
  Files          291      291              
  Lines         9414     9431      +17     
  Branches       681      681              
===========================================
- Hits          7343     7342       -1     
- Misses        2071     2089      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patphongs patphongs changed the title Feature/5259 document type filter Document type filter and MUR & ADR UI changes May 21, 2024
@patphongs
Copy link
Member Author

Closing due to failed package-lock.json

@patphongs patphongs closed this May 23, 2024
@patphongs patphongs deleted the feature/5259-document-type-filter branch May 23, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Build out document type search and update MUR & ADR UI to match
1 participant