Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6207-pin sqlparse to remove snyk vulnerability #6253

Closed
wants to merge 1 commit into from

Conversation

cnlucas
Copy link
Member

@cnlucas cnlucas commented May 9, 2024

Summary (required)

Sqlparse is brought in by Django, we need to pin it to remove a snyk vulnerability until Django updates their min version (they have not yet in the current version)

Required reviewers

2 devs

Impacted areas of the application

General components of the application that this PR will affect:

  • Django

How to test

(Include any information that may be helpful to the reviewer(s). This might include links to sample pages to test or any local environmental setup that is unusual such as environment variable (never credentials), API version to point to, etc)

  1. in dev snyk test --file=requirements.txt --package-manager=pip
  2. Create new virtualenv
  3. pyenv activate <new virtualenv>
  4. pip install -r requirements.txt
  5. npm install
  6. npm run build
  7. pytest
  8. cd fec/
  9. ./manage.py runserver
  10. pytest
  11. snyk test --file=requirements.txt --package-manager=pip sqlparse vuln should be gone

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.92%. Comparing base (18b826d) to head (779352e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6253   +/-   ##
========================================
  Coverage    77.92%   77.92%           
========================================
  Files          289      289           
  Lines         9364     9364           
  Branches       681      681           
========================================
  Hits          7297     7297           
  Misses        2067     2067           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tmpayton tmpayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and everything looks good. thanks @cnlucas!

@cnlucas
Copy link
Member Author

cnlucas commented May 14, 2024

Closing as now the lastest version is being pulled

@cnlucas cnlucas closed this May 14, 2024
@cnlucas cnlucas removed the request for review from pkfec May 14, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Snyk:High] Sqlparse (Due 05/17/24)
2 participants