-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2708 webpack 5 esm #6263
Open
rfultz
wants to merge
64
commits into
develop
Choose a base branch
from
feature/2708-webpack-5-esm
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6263 +/- ##
===========================================
+ Coverage 78.00% 80.59% +2.59%
===========================================
Files 291 232 -59
Lines 9414 4947 -4467
Branches 681 0 -681
===========================================
- Hits 7343 3987 -3356
+ Misses 2071 960 -1111 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Overhauling the front-end's build process and every JavaScript file.
Required reviewers
Impacted areas of the application
The entire front-end where probably every handlebars template is involved, but definitely every JavaScript file and the entire build process including JavaScript, templates, Sass files, etc
Screenshots
Should be zero visual changes
Related PRs
None?
HOW TO TEST
I put together a spreadsheet when I was testing various parts of the site.
▶ CONTENT specifically
▶ UX specifically
Ideally, there should be no visual changes.
▶ DEVS specifically
NPM scripts (
build
,build-production
,test
,test-single
, etc)▶ ALL
NOTE: For localhost, you may need to temporarily launch Chrome without CORS limits. (And only for testing this PR)
open /Applications/Google\ Chrome.app --args --user-data-dir="/var/tmp/chrome-dev-disabled-security" --disable-web-security --disable-site-isolation-trials
console.log
andconsole.debug
TODO
s (do them, make tickets to do them, and/or remove them)