Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2708 webpack 5 esm #6263

Open
wants to merge 64 commits into
base: develop
Choose a base branch
from
Open

Feature/2708 webpack 5 esm #6263

wants to merge 64 commits into from

Conversation

rfultz
Copy link
Contributor

@rfultz rfultz commented May 14, 2024

Summary

Overhauling the front-end's build process and every JavaScript file.

Required reviewers

  • Front-end
  • UX
  • Content
  • Back-end?

Impacted areas of the application

The entire front-end where probably every handlebars template is involved, but definitely every JavaScript file and the entire build process including JavaScript, templates, Sass files, etc

Screenshots

Should be zero visual changes

Related PRs

None?



HOW TO TEST

I put together a spreadsheet when I was testing various parts of the site.

▶ CONTENT specifically

  1. Your testing the admin interface would be invaluable, particularly the more complicated pages' editors
  2. Feel free to poke around the site, try to break everything

▶ UX specifically

Ideally, there should be no visual changes.

  1. Icons, definitely—section icons, doc type, social media, etc. All of them
  2. Then general look, feel, interactivity
  3. across the various widths

▶ DEVS specifically

NPM scripts (build, build-production, test, test-single, etc)

▶ ALL

  • Console: while testing, keep the Inspector's console open and note anything that pops up.
  • Broken down in the spreadsheet, but please add any that were missed
    • Datatables. All of them
    • Filters. All types (checkbox, pulldown, date, numbers, Typeahead, text, multi, etc)
      • Inputmask - date ranges
      • Inputmask - date formatting (correct and incorrect dates)
      • Inputmask - textfilters
    • Interactive parts of website (tables, maps, calculator, filters, etc)
    • Search fields (site-wide header search field, /search/)
    • Legal section
    • Templates, especially the handlebars templates
    • RAD contact form (need to test outside of localhost)
    • Recaptcha (need to test outside of localhost)
    • Feedback (need to test outside of localhost)
    • JavaScript tests
    • Icons
  • Make sure new sitemaps haven't broken

NOTE: For localhost, you may need to temporarily launch Chrome without CORS limits. (And only for testing this PR)
open /Applications/Google\ Chrome.app --args --user-data-dir="/var/tmp/chrome-dev-disabled-security" --disable-web-security --disable-site-isolation-trials

‼️ BEFORE MERGE ‼️

  • Remove console.log and console.debug
  • Address TODOs (do them, make tickets to do them, and/or remove them)
  • Remove excessive commented lines (ex: the old webpack.config parts)

@rfultz rfultz requested a review from patphongs May 14, 2024 13:55
@rfultz rfultz self-assigned this May 14, 2024
@rfultz rfultz removed the request for review from patphongs May 14, 2024 13:58
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.59%. Comparing base (97b6fb7) to head (47df529).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6263      +/-   ##
===========================================
+ Coverage    78.00%   80.59%   +2.59%     
===========================================
  Files          291      232      -59     
  Lines         9414     4947    -4467     
  Branches       681        0     -681     
===========================================
- Hits          7343     3987    -3356     
+ Misses        2071      960    -1111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rfultz rfultz added this to the 25.2 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Upgrade Webpack
1 participant