Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Pin dependencies #558

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Pin dependencies #558

merged 1 commit into from
Dec 21, 2020

Conversation

jason-upchurch
Copy link
Contributor

@jason-upchurch jason-upchurch commented Dec 21, 2020

Resolves #541

How to test

@pkfec @fec-jli , I deployed to dev to verify this works, but probably good for you to test this way as well. Otherwise, just verify nothing looks off to you (I pinned in the requirements_dev.txt because that's where regparser is.

  • make new pyenv 3.7.9 virtualenv
  • pip install {requirements.txt, requirements_test.txt, requirements_dev.txt} (it's the dev that introduced the errors before).
  • To see that no more dependency error exists for django-related packages, you can pip install pipdeptree then run "pipdeptree" and these warnings should be resolved

@jason-upchurch jason-upchurch force-pushed the feature/541-fix-django-related-errors branch from 24e8db2 to bef0772 Compare December 21, 2020 15:44
@jason-upchurch jason-upchurch force-pushed the feature/541-fix-django-related-errors branch from bef0772 to 9985536 Compare December 21, 2020 15:51
@jason-upchurch jason-upchurch self-assigned this Dec 21, 2020
@jason-upchurch jason-upchurch added this to the Sprint 13.10 milestone Dec 21, 2020
Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test locally. parsing works well. great. Thanks

Copy link
Contributor

@pkfec pkfec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to parse 2020 regs with the pinned pkgs on my local. Not seeing any pkg related errors while installing the requirements*. file. Changes looking good @jason-upchurch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible package errors: django-rq, djangorestframework, and requests
3 participants