Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

728-upgrade gitpython #737

Merged
merged 1 commit into from
Jan 4, 2023
Merged

728-upgrade gitpython #737

merged 1 commit into from
Jan 4, 2023

Conversation

cnlucas
Copy link
Member

@cnlucas cnlucas commented Jan 3, 2023

Summary (required)

  • Resolves [Snyk:High] Upgrade gitpython(due by 01/7/2023) #728
    GitPython is in maintenance mode. I did some research and as we use Gitpython for our releases it will be challenging to switch over to Pygit2 or Dulwich, but we will probably need to do it in the future. Currently, GitPython is most widely used and have releases/patches pretty fast.

Required reviewers

1 dev

Impacted areas of the application

General components of the application that this PR will affect:

  • Interaction with git libraries, automated release process

How to test

(Include any information that may be helpful to the reviewer(s). This might include links to sample pages to test or any local environmental setup that is unusual such as environment variable (never credentials), API version to point to, etc)

  • checkout and pull the latest develop branch
  • run snyk test --all-projects. Shows vulnerability.
  • gh pr checkout
  • run pip install -r requirements.txt
  • run pip install -r requirements-parsing.txt
  • run snyk test --all-projects
  • run pytest
  • python manage.py runserver

@pkfec
Copy link
Contributor

pkfec commented Jan 3, 2023

  • run pytest
    @cnlucas We do not have pytest setup for eregs. You can remove from How to test instructions above! Rest looks good.

@pkfec pkfec merged commit 77206e2 into develop Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Snyk:High] Upgrade gitpython(due by 01/7/2023)
2 participants