Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research moving proxy to NGINX buildpack #200

Closed
6 tasks
Tracked by #137
lbeaufort opened this issue Nov 16, 2020 · 1 comment · Fixed by #234
Closed
6 tasks
Tracked by #137

Research moving proxy to NGINX buildpack #200

lbeaufort opened this issue Nov 16, 2020 · 1 comment · Fixed by #234

Comments

@lbeaufort
Copy link
Member

lbeaufort commented Nov 16, 2020

Follow-up from #169, WIP PR here: #171, we should move the proxy to NGINX buildpack

**WARNING** overriding nginx.conf is deprecated and highly discouraged, 
as it breaks the functionality of the Staticfile and Staticfile.auth configuration directives. 
Please use the NGINX buildpack available at: https://github.com/cloudfoundry/nginx-buildpack

See research here: #169 (comment) and later discussion

Looks like this repo uses nginx buildpack: https://github.com/cloud-gov/docker-registry-mirror/tree/5fdffe51c6aa3b31bd95e42fc55bc1ed91af409b/proxy. One of the challenges is finding out how to do the syntax for some of the more complex logic we have in the conf file.

Technical consideration

  • get cloud.gov research support to understand complexity
  • if desired:
    • Move proxy to NGINX buildpack, re-write NGINX conf file
    • Put in follow-up issue for the proxy-redirect app

Completion criteria

  • Meet with cloud.gov team to assess upgrading to the new NGINX buildpack
  • Implement the changes and see proxy is running on the new buildpack
@lbeaufort
Copy link
Member Author

Moving to 13.11 due to scheduling issues with supplemental support hours

@lbeaufort lbeaufort modified the milestones: Sprint 13.10, Sprint 13.11 Dec 15, 2020
@patphongs patphongs removed this from the Sprint 13.11 milestone Dec 22, 2020
@lbeaufort lbeaufort added this to the Sprint 13.12 milestone Jan 4, 2021
@lbeaufort lbeaufort changed the title Move proxy to NGINX buildpack Research moving proxy to NGINX buildpack Jan 11, 2021
@lbeaufort lbeaufort self-assigned this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants