Merge pull request #45 from 18F/zeros

Fixing 0 -> unavailable

openfecwebapp/data_prep/financial_summaries.py

@@ -24,7 +24,7 @@ def _map_committee_financials(vals):
 
     # format totals data in US dollars
     for v in value_map:
-        if value_map[v]:
+        if value_map[v] is not None:
             totals_mapped[v] = locale.currency(
             value_map[v], grouping=True)
 

openfecwebapp/tests/data_prep/financial_summaries_tests.py

@@ -22,6 +22,17 @@ def test_map_committee_financials(self):
         self.assertEqual('2009 - 2010', c['years_totals'])
         self.assertEqual('End Report ', c['report_desc'])
 
+        results = {
+            'reports': totals['results'][1]['reports'][0],
+            'totals': totals['results'][1]['totals'][0]
+        }
+        c = _map_committee_financials(results)
+
+        self.assertEqual('$0.00', c['total_receipts'])
+        self.assertEqual('$0.00', c['total_disbursements'])
+        self.assertEqual('$0.00', c['total_cash'])
+        self.assertEqual('$0.00', c['total_debt'])
+
     def test_get_reports_totals_results(self):
         c = _get_reports_totals_results(totals['results'][0])
 

openfecwebapp/tests/mock_data.py

@@ -84,6 +84,20 @@
             'disbursements': 3453.54
         }],
         'committee_id': 'D1234'
+    },
+    {
+        'reports': [{
+            'cash_on_hand_end_period': 0,
+            'debts_owed_by_committee': 0,
+            'report_year': 2010,
+            'election_cycle': 2010,
+            'report_type_full': 'End Report {stuff}'
+        }],
+        'totals': [{
+            'receipts': 0,
+            'disbursements': 0
+        }],
+        'committee_id': 'D1234'
     }]
 }