This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Feature/perf bar #242
Merged
Feature/perf bar #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,5 +14,8 @@ <h1 id="hero-heading" class="text--display">Explore Campaign Finance Data</h1> | |||
| </div> | |||
| </form> | |||
| </div> | |||
| <script type="application/javascript"> | |||
There was a problem hiding this comment.
Should this be wrapped in {% if debug %}...{% endif %}?
There was a problem hiding this comment.
I actually want these performance marks to be present all the time. I can explain more in a meeting, but essentially these are custom metrics that we could track for various pages. If we keep these marks, it means that performance tracking tools like new relic, or google analytics will automatically pick them up.
There was a problem hiding this comment.
Oh, that's cool. Didn't know window.performance.mark was a thing!
Feature/perf bar
|
@msecret do we have to do anything to get the extra performance metrics into New Relic? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.