Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Feature/adding preview to disbursements #406

Merged
merged 5 commits into from
Aug 4, 2015

Conversation

noahmanger
Copy link
Contributor

@msecret already did all the work. I just had to do a couple things to get the preview pane to show up on /disbursements.

<div class="modal">
<div class="modal__row">
<button title="Close menu" class="js-hide modal__close" data-hides="datatable-modal"><i class="ti-close"></i></button>
<div id="datatable-modal" class="panel__overlay" aria-hidden="true">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make this a partial as it's quite a bit of duplicated code. Although, does it only appear in these two files, or is there a chance it will be in more files?

Noah Manger added 2 commits August 3, 2015 17:09
…-disbursements

Merging in separate work I did to refactor the filings page slightly
@noahmanger
Copy link
Contributor Author

Just added typeahead to committee filters on /filings and /disbursements to resolve #397

@noahmanger
Copy link
Contributor Author

I don't get why these tests are failing :(

@msecret
Copy link
Contributor

msecret commented Aug 4, 2015

The test failures seem to indicate that the results in the tables aren't being populated. There's a bunch of failures to find <tr> elements, like this selector: tbody tr or even this .tst-search_results h3 a. Is it possible that the API wasn't working or was down while the tests ran? I'm not super familiar with the tests setup. @jmcarp would know more.

@jmcarp
Copy link
Contributor

jmcarp commented Aug 4, 2015

I'm looking into this more in #414, hoping to have this figured out soon. Meanwhile, tests are passing for me locally, so I'm going to merge.

@jmcarp jmcarp merged commit 5b67823 into develop Aug 4, 2015
@jmcarp jmcarp removed the plz-review label Aug 4, 2015
@jmcarp jmcarp deleted the feature/adding-preview-to-disbursements branch October 2, 2015 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants