Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Feature/updating receipts tab #439

Merged
merged 7 commits into from
Aug 6, 2015
Merged

Conversation

noahmanger
Copy link
Contributor

With receipt aggregates now separated by those from individuals and those from committees, this updates the layout of the receipts tab to reflect the division:

screen shot 2015-08-06 at 10 44 43 am

This will resolve #339

<h2 class="section-heading" id="section-2-heading">Analyze Receipts {% include 'partials/cycle-select.html' %} </h2>
<div class="toggles section__intro__left">
<span class="label">Compare by:</span>
<div class="section__intro__left">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "left" part sounds more like a modifier, so should probably be --left. If there are too many places this would have to change, I don't care that much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. In this case I meant it as the left-side element on the section intro. I don't mind either way.

@msecret
Copy link
Contributor

msecret commented Aug 6, 2015

Some of these selenium failures may seem valid. Like this one:

 AssertionError: 'Oops: We messed up' != 'A WHOLE LOT OF PEOPLE FOR GRIJALVA CONGRESSIONAL COMMITTEE'
E       - Oops: We messed up
E       + A WHOLE LOT OF PEOPLE FOR GRIJALVA CONGRESSIONAL COMMITTEE

It seems like we're changing the text that appears for when something goes wrong.

Also, "WHOLE LOT OF PEOPLE FOR GRIJALVA CONGRESSIONAL COMMITTEE" is an awesome committee name.

But this ^ could also mean that search results aren't returning correctly because it can't find .tst-search_results h5 a elements or tbody tr.

@noahmanger
Copy link
Contributor Author

I think the issue with that failure is that it's showing the error message ("Oops: we messed up") rather than the committee result. Based on all the other failures, it seems like it's just not getting any data.

@msecret
Copy link
Contributor

msecret commented Aug 6, 2015

I'm fine merging then, but @jmcarp this is a potential example of the tests failing randomly.

msecret pushed a commit that referenced this pull request Aug 6, 2015
@msecret msecret merged commit b08ec0e into develop Aug 6, 2015
@msecret msecret removed the plz-review label Aug 6, 2015
@jmcarp jmcarp deleted the feature/updating-receipts-tab branch October 2, 2015 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style Contributions tab
2 participants