-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
…/updating-receipts-tab
…/updating-receipts-tab
…/updating-receipts-tab Conflicts: templates/partials/receipts-tab.html
<h2 class="section-heading" id="section-2-heading">Analyze Receipts {% include 'partials/cycle-select.html' %} </h2> | ||
<div class="toggles section__intro__left"> | ||
<span class="label">Compare by:</span> | ||
<div class="section__intro__left"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "left" part sounds more like a modifier, so should probably be --left
. If there are too many places this would have to change, I don't care that much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm. In this case I meant it as the left-side element on the section intro. I don't mind either way.
Some of these selenium failures may seem valid. Like this one:
It seems like we're changing the text that appears for when something goes wrong. Also, "WHOLE LOT OF PEOPLE FOR GRIJALVA CONGRESSIONAL COMMITTEE" is an awesome committee name. But this ^ could also mean that search results aren't returning correctly because it can't find |
I think the issue with that failure is that it's showing the error message ("Oops: we messed up") rather than the committee result. Based on all the other failures, it seems like it's just not getting any data. |
I'm fine merging then, but @jmcarp this is a potential example of the tests failing randomly. |
With receipt aggregates now separated by those from individuals and those from committees, this updates the layout of the receipts tab to reflect the division:
This will resolve #339