Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub] [High] Signature Malleabillity in elliptic (due 9/25/20) #4585

Closed
1 of 3 tasks
lbeaufort opened this issue Aug 26, 2020 · 1 comment · Fixed by #4597
Closed
1 of 3 tasks

[GitHub] [High] Signature Malleabillity in elliptic (due 9/25/20) #4585

lbeaufort opened this issue Aug 26, 2020 · 1 comment · Fixed by #4597
Assignees
Labels
Security: high Remediate within 30 days
Milestone

Comments

@lbeaufort
Copy link
Member

lbeaufort commented Aug 26, 2020

Remediation
Upgrade elliptic to version 6.5.3 or later. For example:

"dependencies": {
  "elliptic": ">=6.5.3"
}

or…

"devDependencies": {
  "elliptic": ">=6.5.3"
}

Always verify the validity and compatibility of suggestions with your codebase.

Details
CVE-2020-13822
high severity
Vulnerable versions: < 6.5.3
Patched version: 6.5.3
The Elliptic package before version 6.5.3 for Node.js allows ECDSA signature malleability via variations in encoding, leading '\0' bytes, or integer overflows. This could conceivably have a security-relevant impact if an application relied on a single canonical signature.

Action item:

  • Update the package and see if it breaks
  • If there are any errors, make sure it's a vulnerability before working on those errors

Completion criteria:

  • Vulnerability is explored and addresses as appropriate
@jason-upchurch
Copy link
Contributor

This vulnerability is in a dev dependency thus not flagged by snyk. To reproduce

snyk test --file=package-lock.json --dev

The typical snyk test --file=package-lock will not pick it up as a vulnerability.

Will patch and commit new package-lock.json after testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security: high Remediate within 30 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants