Use Flask-CORS for more robust CORS configuration. #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API currently uses the `Access-Control-Allow-Origin` header, but not the `Access-Control-Allow-Headers` header. This leads to CORS errors when using Safari, which sends the `Accept-Encoding` header with its `OPTIONS` requests. Rather than allowing the `Accept-Encoding` header, this patch switches to Flask-CORS for CORS configuration, which has better defaults and is easier to configure than settings CORS headers manually. [Resolves fecgov/openFEC-web-app#462]
|
Thanks for figuring this out! |
LindsayYoung
added a commit
that referenced
this pull request
Aug 12, 2015
Use Flask-CORS for more robust CORS configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API currently uses the
Access-Control-Allow-Originheader, but notthe
Access-Control-Allow-Headersheader. This leads to CORS errorswhen using Safari, which sends the
Accept-Encodingheader with itsOPTIONSrequests. Rather than allowing theAccept-Encodingheader,this patch switches to Flask-CORS for CORS configuration, which has
better defaults and is easier to configure than settings CORS headers
manually.
Thanks @onezerojeremy and @noahmanger for help with debugging.
[Resolves https://github.com/fecgov/openFEC-web-app/issues/462]