[MERGE WITH GIT FLOW] Hotfix/4538 fix api key signup load

[jason-upchurch]

Summary (required)

• Resolves Fix API key sign up load problem #4538

Include a summary of proposed changes.

• remove feature flag
• additional js changes (@johnnyporkchops, @rfultz )

How to test the changes locally

This bug is sometimes hard to reproduce. But @johnnyporkchops and @jason-upchurch confirmed we were able to reproduce on local. So:

• clear browser history
• check out master branch
• run local api, see if form loads, try refreshing until form does not load
• clear browser history (again)
• check out this hotfix branch
• run local api
• test that api key signup form loads with page, refresh, etc.

Impacted areas of the application

List general components of the application that this PR will affect:

• rest.py
• swagger-ui.html
• docs.py

[fec-jli]

I can reproduce the bug locally. after checking in the hotfix branch, re-try many times, not appear any more. great work. Thanks

[jason-upchurch]

@JonellaCulmer I added you as a reviewer because we wanted to make sure the operation of the api signup form loading was acceptable from a usability standpoint. Thanks for your review!

It's still in the process of deploying, but when done, it will be available for review: https://fec-dev-api.app.cloud.gov/developers/

[jason-upchurch]

@rfultz thank you for your tremendous support today with tweaking the js to get the form loading consistently! I really appreciate your collaboration on this effort and your help in all of our success :)
cc @patphongs

[johnnyporkchops]

We are using. a setTimeout to ensure the form is loaded every time. While not ideal, it seems to solve the issue. I was hesitant to suggest this solution before, but feel a little more confident with the sign-off of another frontend dev.

[JonellaCulmer]

Tested across two browsers and incognito mode and no issues found. The form now loads consistently each time. Some slight delays, but nothing severe.