5294 -upgrade gitpython #5309
Merged
5294 -upgrade gitpython #5309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
GitPython is in maintenance mode. I did some research and as we use Gitpython for our automated releases it will be challenging to switch over to Pygit2 or Dulwich, but we will probably need to do it in the future. Currently, GitPython is most widely used and have releases/patches pretty fast.
Required reviewers
1 dev
Impacted areas of the application
General components of the application that this PR will affect:
Screenshots
Before:
After:
How to test
developbranchsnyk test --all-projects. Shows vulnerability.gh pr checkout 5309pip install -r requirements.txtpip install -r requirements-dev.txtsnyk test --all-projectspytestflask run