Skip to content
This repository has been archived by the owner on Sep 12, 2018. It is now read-only.

Add option to render all connected components at once #93

Closed
fedarko opened this issue Sep 27, 2016 · 1 comment
Closed

Add option to render all connected components at once #93

fedarko opened this issue Sep 27, 2016 · 1 comment
Assignees

Comments

@fedarko
Copy link
Owner

fedarko commented Sep 27, 2016

I guess this would be done in the viewer. We could do this by taking the bounding boxes for each component and "concatenating" them, with some margins in between. (For some reason, laying out components individually seems to be faster than laying out the entire graph at once—so we'd still generate layouts on a component-by-component basis, but just concatenate the resulting layouts to produce something basically equivalent.

This probably shouldn't be the default behavior (will wreck viewer performance for huge graphs that have sizable non-largest components) but having it as an option would be useful in some cases (e.g. graphs composed of a lot of tiny component fragments).

@fedarko fedarko self-assigned this Sep 27, 2016
fedarko added a commit that referenced this issue Feb 12, 2017
The scaling applies to whatever's being drawn, so it adjusts as
different components/etc. are drawn. When we implement the ability
to draw multiple components at once (see #93), we can adjust this
to scale accordingly to the increased size.

This results in a pretty huge speedup, which is great! I think the
slightly choppy progress bar animations are more than an alright
cost, and we can probably look into making that a bit smoother
in the future (but that's super low priority relative to tons of
other stuff).
@fedarko fedarko changed the title Add option to render all components at once Add option to render all connected components at once Feb 25, 2017
@fedarko
Copy link
Owner Author

fedarko commented Aug 9, 2017

This issue was moved to marbl/MetagenomeScope#16

@fedarko fedarko closed this as completed Aug 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant