Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds endurance test #1103

Merged
merged 3 commits into from
May 29, 2024
Merged

adds endurance test #1103

merged 3 commits into from
May 29, 2024

Conversation

srcansiz
Copy link
Member

PR description

Developer Certificate Of Origin (DCO)

By opening this merge request, you agree to the
Developer Certificate of Origin (DCO)

This DCO essentially means that:

  • you offer the changes under the same license agreement as the project, and
  • you have the right to do that,
  • you did not steal somebody else’s work.

License

Project code files should begin with these comment lines to help trace their origin:

# This file is originally part of Fed-BioMed
# SPDX-License-Identifier: Apache-2.0

Code files can be reused from another project with a compatible non-contaminating license.
They shall retain the original license and copyright mentions.
The CREDIT.md file and credit/ directory shall be completed and updated accordingly.

Guidelines for PR review

General:

Specific to some cases:

  • update all conda envs consistently (development and vpn, Linux and MacOS)
  • if modified researcher (eg new attributes in classes) check if breakpoint needs update (breakpoint/load_breakpoint in Experiment(), save_state_breakpoint/load_state_breakpoint in aggregators, strategies, secagg, etc.)
  • if modified a component with versioning (config files, breakpoint, messaging protocol) then update the version following the rules in common/utils/_versions.py

@srcansiz srcansiz self-assigned this May 15, 2024
@srcansiz srcansiz force-pushed the feature/long-running-e2e-test branch from cb26346 to 4d4a448 Compare May 15, 2024 08:56
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (182524d) to head (fb2c494).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1103   +/-   ##
========================================
  Coverage    88.81%   88.81%           
========================================
  Files           89       89           
  Lines        10285    10285           
========================================
  Hits          9135     9135           
  Misses        1150     1150           
Flag Coverage Δ
unittests-fedora38 88.81% <ø> (ø)
unittests-ubuntu-22-04 88.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srcansiz srcansiz force-pushed the feature/long-running-e2e-test branch 4 times, most recently from 8782cb4 to b6c1aa1 Compare May 21, 2024 13:18
@srcansiz srcansiz changed the title adds long running test adds endurance test May 21, 2024
@srcansiz srcansiz requested a review from ybouilla May 21, 2024 13:20
@srcansiz srcansiz force-pushed the feature/long-running-e2e-test branch from 2f66cdf to 28f1e89 Compare May 29, 2024 15:51
srcansiz and others added 3 commits May 29, 2024 17:52
Since endurance / stress tests are very long processes that iterate model training over a huge number of rounds,
 it is needed to set `retain_full_history` to False
clean envrionment after endurance tests

allow cleaning failure in github actions

disable endurance test running for feature branch pushes

use power of to 2 for the neurons
@srcansiz srcansiz force-pushed the feature/long-running-e2e-test branch from 28f1e89 to fb2c494 Compare May 29, 2024 15:53
@srcansiz srcansiz enabled auto-merge May 29, 2024 15:53
@srcansiz srcansiz merged commit f7e483d into develop May 29, 2024
9 checks passed
@srcansiz srcansiz deleted the feature/long-running-e2e-test branch May 29, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants