This repository has been archived by the owner on May 7, 2024. It is now read-only.
System Download Limit Handling #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there and thanks for your contribution! I accidentally merged the previous PR believing it was a way to bypass the download limit. I think we should be a little careful about this. If a user tries downloading and the limit is hit, the app will just hang without any alert. The more than 10-minute wait can make it seem like a bug, when in fact it is not; I doubt a user would wait around 10 minutes thinking everything is working fine. This should be either an option or it should be easy to see the reason why (e.g. in form of a popup) with maybe some extra info, such as using a VPN can bypass the problem |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to system constraints that permit the download of only up to 330 files at once, we've introduced a global variable named REQUEST_COUNT. If the file count exceeds 330, this variable helps determine if a 15-minute wait is necessary before proceeding with additional downloads.