Add CSS content support - Fixes #319 #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this is probably a major breaking change since I changed the params sent into |
There was a problem hiding this comment.
Looking great already! I have one concern regarding the loading of the CSS.
In general I think the README could use a small update to explain the different was of including CSS as the css-content config you introduced might be valuable for others as well. Do you think you can pick that up?
| { | ||
| $filesToInline = $this->config['css-files'] ?? []; | ||
|
|
||
| $this->cssToAlwaysInclude = $this->loadCssFromFiles($filesToInline); |
There was a problem hiding this comment.
If both functions are used to add to the $this->cssToAlwaysInclude perhaps it would be best to also use the .= here as then the order of method calling has no side effects.
Suggested change
| $this->cssToAlwaysInclude = $this->loadCssFromFiles($filesToInline); | |
| $this->cssToAlwaysInclude .= $this->loadCssFromFiles($filesToInline); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DannyvdSluijs for your approval.