First commit of 2016 :-) Removed adapte recreation

fedepaol · Jan 1, 2016 · 2a7181e · 2a7181e
1 parent 16a5863
commit 2a7181e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/app/src/main/java/com/whiterabbit/rxrestsample/CachedActivity.java b/app/src/main/java/com/whiterabbit/rxrestsample/CachedActivity.java
@@ -49,6 +49,7 @@ public class CachedActivity extends AppCompatActivity implements SwipeRefreshLay
 
     private Observable<List<Repo>> mObservable;
     private Observable<String> mProgressObservable;
+    private RepoAdapter mAdapter;
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {
@@ -62,15 +63,16 @@ protected void onCreate(Bundle savedInstanceState) {
         mSwipeLayout.setOnRefreshListener(this);
         mObservable = mRepo.getDbObservable();
         mProgressObservable = mRepo.getProgressObservable();
+        mAdapter = new RepoAdapter();
+        mList.setAdapter(mAdapter);
     }
 
     @Override
     protected void onResume() {
         super.onResume();
         mObservable.subscribeOn(Schedulers.io())
                    .observeOn(AndroidSchedulers.mainThread()).subscribe(l -> {
-                    RepoAdapter a = new RepoAdapter(l);
-                    mList.setAdapter(a);
+                    mAdapter.updateData(l);
                 });
 
         fetchUpdates();

diff --git a/app/src/main/java/com/whiterabbit/rxrestsample/NonCachedActivity.java b/app/src/main/java/com/whiterabbit/rxrestsample/NonCachedActivity.java
@@ -28,6 +28,7 @@ public class NonCachedActivity extends AppCompatActivity {
     @Bind(R.id.pending_request_progress) ProgressBar mProgress;
     @Bind(R.id.main_list) RecyclerView mList;
     private Observable<List<Repo>> mObservable;
+    private RepoAdapter mAdapter;
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {
@@ -38,6 +39,8 @@ protected void onCreate(Bundle savedInstanceState) {
 
         LinearLayoutManager layoutManager = new LinearLayoutManager(getApplicationContext());
         mList.setLayoutManager(layoutManager);
+        mAdapter = new RepoAdapter();
+        mList.setAdapter(mAdapter);
     }
 
     @Override
@@ -48,9 +51,8 @@ protected void onResume() {
         mObservable.delay(3, TimeUnit.SECONDS) // delayed for demonstration purpouse
                    .subscribeOn(Schedulers.io())
                    .observeOn(AndroidSchedulers.mainThread()).subscribe(l -> {
-                    RepoAdapter a = new RepoAdapter(l);
-                    mList.setAdapter(a);
                     mProgress.setVisibility(View.INVISIBLE);
+                    mAdapter.updateData(l);
                 },
                 e -> mProgress.setVisibility(View.INVISIBLE),
                 ()-> mProgress.setVisibility(View.INVISIBLE));

diff --git a/app/src/main/java/com/whiterabbit/rxrestsample/adapters/RepoAdapter.java b/app/src/main/java/com/whiterabbit/rxrestsample/adapters/RepoAdapter.java
@@ -26,6 +26,7 @@
 import com.whiterabbit.rxrestsample.R;
 import com.whiterabbit.rxrestsample.data.Repo;
 
+import java.util.ArrayList;
 import java.util.List;
 
 import butterknife.Bind;
@@ -34,8 +35,13 @@
 public class RepoAdapter extends RecyclerView.Adapter<RepoAdapter.RepoViewHolder> {
     private List<Repo> mRepos;
 
-    public RepoAdapter(List<Repo> repos) {
+    public RepoAdapter() {
+        mRepos = new ArrayList<>(0);
+    }
+
+    public void updateData(List<Repo> repos) {
         mRepos = repos;
+        notifyDataSetChanged();
     }
 
     @Override