Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Adopt rustfmt formatting for the project. #137

Closed
matt-h opened this issue Dec 11, 2019 · 3 comments
Closed

Suggestion: Adopt rustfmt formatting for the project. #137

matt-h opened this issue Dec 11, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@matt-h
Copy link
Contributor

matt-h commented Dec 11, 2019

cargo fmt currently makes a many changes throughout the project.

A suggestion would be to adopt using the rustfmt style auto-formatter to make the project consistent with other rust projects.

@federico-terzi
Copy link
Collaborator

Hi @matt-h,

That's surely a great suggestion. Considering the number of resulting changes, it would be better to ship it in a major release probably.

What do you think about it?

Thanks for your help

@federico-terzi federico-terzi added the enhancement New feature or request label Dec 11, 2019
@matt-h
Copy link
Contributor Author

matt-h commented Dec 11, 2019

That is fine to wait for that.

Although it is pretty much just whitespace changes of the code so shouldn't result it any feature changes. Tests all passed still after I tried it.

I mostly just noticed because I had to turn off the rust auto formatter in my editor when making a change otherwise it was changing a lot of code.

@federico-terzi
Copy link
Collaborator

Glad to hear that, I'll keep you updated.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants