Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case propagation applying when it should not #252

Closed
femtocept opened this issue Apr 28, 2020 · 5 comments
Closed

Case propagation applying when it should not #252

femtocept opened this issue Apr 28, 2020 · 5 comments
Labels
bug Something isn't working RFNR Ready to be shipped in next release

Comments

@femtocept
Copy link

femtocept commented Apr 28, 2020

Hey Federico,

I noticed that expansions get triggered when they should not be if they are propagate case. A simple example for you to test this below:

  - trigger: "ther"
    replace: "there"
    propagate_case: true
    word: true

Testing:

  • "ther" "Ther" and "THER" all correct properly, yes.
  • type "other", it's fine with no match
  • type "Other" and it will correct to Othere
  • type "Xther" and it will correct to Xthere
  • type "OTHER" and it's fine with no match

It still happens if I change it to "thex" and "thexe" so I do not think it has to do with other matches I have configured. I don't use nested matches anywhere.

It might have something to do with the initial capital match but not the others.

I am currently on a Mac with espanso 0.5.5

Thanks for everything.
BM

@federico-terzi
Copy link
Collaborator

Hey @femtocept,

Thanks for the feedback, this is definitely a bug! I'll do my best to fix it in the next release :)

Cheers

@federico-terzi federico-terzi added the bug Something isn't working label Apr 28, 2020
@yksyks
Copy link

yksyks commented May 1, 2020

Here it's even worse: even the published example without the propagate_case directive doesn't work. It generates othere. (Windows 10 Home, Estenso 0.5.5)

@federico-terzi
Copy link
Collaborator

Here it's even worse: even the published example without the propagate_case directive doesn't work. It generates othere. (Windows 10 Home, Estenso 0.5.5)

You are right, I've just tested it on Windows. Thanks for pointing that out :)

@yksyks
Copy link

yksyks commented May 1, 2020

I thank you for your effort. I am new here, so at first I was afraid that I'm doing some mistake.

federico-terzi added a commit that referenced this issue May 2, 2020
federico-terzi added a commit that referenced this issue May 2, 2020
@federico-terzi federico-terzi added the RFNR Ready to be shipped in next release label May 10, 2020
@federico-terzi
Copy link
Collaborator

Hey,
I'm currently releasing espanso 0.6.0 that also fixes this bug, so don't forget to update :)
Let me know if you experience any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working RFNR Ready to be shipped in next release
Projects
None yet
Development

No branches or pull requests

3 participants