Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set trim option for shell script default to true #272

Closed
atika opened this issue May 11, 2020 · 1 comment
Closed

Set trim option for shell script default to true #272

atika opened this issue May 11, 2020 · 1 comment
Labels
enhancement New feature or request RFNR Ready to be shipped in next release

Comments

@atika
Copy link

atika commented May 11, 2020

Most of the usage of shell script expander is for returning a simple text variable for a template, most of the commands return a new line at the end.
I think that the result returned by the script should have to be trimmed by default to avoid unexpected results. I personally have to set this option everywhere, when I started using this I was surprised to see that the terminal tried to execute the returned text as a command.

@federico-terzi
Copy link
Collaborator

Hey @atika,
This is indeed a good point. I'll keep the issue open for discussion, and if no-one raises any concern, I'll implement it in the next release.

Thanks for your help :)

@federico-terzi federico-terzi added the enhancement New feature or request label May 11, 2020
@federico-terzi federico-terzi added the RFNR Ready to be shipped in next release label May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request RFNR Ready to be shipped in next release
Projects
None yet
Development

No branches or pull requests

2 participants