Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User defined matches should have higher priority than package matches #273

Closed
atika opened this issue May 11, 2020 · 3 comments
Closed

User defined matches should have higher priority than package matches #273

atika opened this issue May 11, 2020 · 3 comments
Labels
bug Something isn't working RFNR Ready to be shipped in next release

Comments

@atika
Copy link

atika commented May 11, 2020

When I installed a package I immediately thought if there was a way to overwrite or disable one of the expanders of it.
I tried with the emoji package and wanted to overwrite the :sad expander by creating a new one in the default YAML config file.
But this doesn't worked as expected because the package takes precedence to the default local file and the text replaced is from the package and not from the user config file.

@federico-terzi
Copy link
Collaborator

Hey
I agree with you on this one, the default config should have a higher priority than packages.
I'll make sure to fix this behavior in the next release.

Thanks for your help :)

@federico-terzi federico-terzi added the bug Something isn't working label May 11, 2020
@federico-terzi federico-terzi changed the title Expander priority User defined matches should have higher priority than package matches May 11, 2020
@atika
Copy link
Author

atika commented May 11, 2020

Thanks for you work, and to rename my title 😂

@federico-terzi
Copy link
Collaborator

No problem, thanks for pointing that out :)

@federico-terzi federico-terzi added the RFNR Ready to be shipped in next release label May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working RFNR Ready to be shipped in next release
Projects
None yet
Development

No branches or pull requests

2 participants