Add a disconnect method #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
|
Ping |
yi-gu
reviewed
Nov 20, 2023
yi-gu
reviewed
Nov 20, 2023
|
lgtm |
cbiesinger
approved these changes
Nov 28, 2023
samuelgoto
reviewed
Nov 29, 2023
samuelgoto
reviewed
Nov 29, 2023
samuelgoto
reviewed
Nov 29, 2023
samuelgoto
approved these changes
Nov 29, 2023
|
LGTM @bvandersloot-mozilla WDYT? |
TallTed
reviewed
Nov 30, 2023
TallTed
reviewed
Nov 30, 2023
TallTed
reviewed
Nov 30, 2023
|
I think I follow and LGTM. |
Thanks @bvandersloot-mozilla ! @npm1 i'll wait for you to resolve the last remaining bits of feedback from @TallTed and then squash and merge. |
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
github-actions bot
added a commit
that referenced
this pull request
Dec 1, 2023
SHA: baf2b3d Reason: push, by npm1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to mattdanielbrown/WebID
that referenced
this pull request
Dec 2, 2023
SHA: baf2b3d Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #496. Adds a
disconnect_endpointand adisconnectmethod to allow the RP to request the IDP to disconnect a previously connected federated account. I opted fordisconnect_endpointinstead ofdisconnection_endpointbecause it sounded a bit better to me, but open to change it. The credentialed request is sent with IDP cookies but using CORS as the request mode. If no account is found or there is some other error, the user agent removes all connections associated with the RP, IDP.Preview | Diff