Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing client DB migration in #3820 #4700

Closed
elsirion opened this issue Mar 23, 2024 · 0 comments · Fixed by #4707
Closed

Missing client DB migration in #3820 #4700

elsirion opened this issue Mar 23, 2024 · 0 comments · Fixed by #4707
Assignees
@m1sterc001guy
Labels
bug Something isn't working client lightning Lightning module
Milestone
0.3.0

Comments

@elsirion
Copy link
Contributor

elsirion commented Mar 23, 2024 •
edited

We forgot to add a migration for LightningReceiveConfirmedInvoice, which also had KeyPair changed to ReceivingKey:

fedimint/modules/fedimint-ln-client/src/receive.rs

Lines 188 to 191 in 64468b6

pub struct LightningReceiveConfirmedInvoice {
invoice: Bolt11Invoice,
receiving_key: ReceivingKey,
}

Introduced in #3820
@elsirion elsirion added bug Something isn't working lightning Lightning module client labels Mar 23, 2024
@elsirion elsirion added this to the 0.3.0 milestone Mar 23, 2024
@m1sterc001guy m1sterc001guy mentioned this issue Mar 23, 2024
Merged
@m1sterc001guy m1sterc001guy self-assigned this Mar 23, 2024
@elsirion elsirion mentioned this issue Mar 23, 2024
Merged
elsirion added a commit to elsirion/fedimint that referenced this issue Mar 23, 2024
@elsirion
chore: add logging and invariant enforcement
59614fe 
This was useful while debugging fedimint#4700 and fedimint#4699
@benthecarman benthecarman mentioned this issue Mar 23, 2024
Merged
github-actions bot pushed a commit that referenced this issue Mar 24, 2024
@elsirion @github-actions
chore: add logging and invariant enforcement
2470ed6 
This was useful while debugging #4700 and #4699

(cherry picked from commit 59614fe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m1sterc001guy m1sterc001guy

Labels
bug Something isn't working client lightning Lightning module
Projects
Roadmap
Status: No status
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Add missing state machine migration elsirion/fedimint
2 participants
@m1sterc001guy @elsirion