Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: new backup/recovery API #3008

Closed
wants to merge 10 commits into from

Conversation

elsirion
Copy link
Contributor

Working towards #2977

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Attention: 345 lines in your changes are missing coverage. Please review.

Comparison is base (59ca43d) 59.05% compared to head (5a1b038) 58.66%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3008      +/-   ##
==========================================
- Coverage   59.05%   58.66%   -0.40%     
==========================================
  Files         190      191       +1     
  Lines       39990    40341     +351     
==========================================
+ Hits        23617    23665      +48     
- Misses      16373    16676     +303     
Files Coverage Δ
fedimint-core/src/macros.rs 26.56% <100.00%> (ø)
fedimint-core/src/core.rs 11.15% <0.00%> (ø)
modules/fedimint-mint-client/src/backup.rs 0.00% <0.00%> (ø)
gateway/ln-gateway/src/state_machine/mod.rs 90.69% <0.00%> (-1.51%) ⬇️
modules/fedimint-ln-client/src/lib.rs 86.96% <0.00%> (-0.68%) ⬇️
modules/fedimint-wallet-client/src/lib.rs 86.25% <0.00%> (-1.28%) ⬇️
modules/fedimint-dummy-client/src/lib.rs 86.27% <0.00%> (-2.44%) ⬇️
fedimint-client/src/module/init.rs 72.72% <0.00%> (-10.39%) ⬇️
modules/fedimint-mint-client/src/lib.rs 64.97% <0.00%> (-0.07%) ⬇️
fedimint-client/src/module/mod.rs 39.22% <0.00%> (-3.91%) ⬇️
... and 2 more

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elsirion elsirion force-pushed the 2023-08-backup-recovery branch 5 times, most recently from dd534b4 to 2925b32 Compare August 29, 2023 15:24
dpc
dpc previously approved these changes Aug 31, 2023
@elsirion elsirion force-pushed the 2023-08-backup-recovery branch 3 times, most recently from 756bf79 to 71777d6 Compare September 11, 2023 11:10
Comment on lines +106 to +111
async fn process_ci(
&mut self,
dbtx: &mut ModuleDatabaseTransaction<'_>,
contributor: PeerId,
ci: <<Self::ClientModule as ClientModule>::Common as ModuleCommon>::ConsensusItem,
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need access to the API here?

@elsirion
Copy link
Contributor Author

elsirion commented Nov 2, 2023

Call with @dpc:

  • What if one module stalls?
    • Maybe independent recovery
    • Get module should check if recovery is finished
  • Keep using state machines, just don't store old states
  • Let Client drive recovery, keep track of SMs that are doing recovery
  • Separate init fn that return recovery SM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants