Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: fix: don't limit max number of concurrent requests #3470

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

douglaz
Copy link
Contributor

@douglaz douglaz commented Oct 27, 2023

Related to #3406

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d286ede) 59.34% compared to head (3c63aa9) 58.94%.
Report is 14 commits behind head on releases/v0.1.

Additional details and impacted files
@@                Coverage Diff                @@
##           releases/v0.1    #3470      +/-   ##
=================================================
- Coverage          59.34%   58.94%   -0.41%     
=================================================
  Files                210      214       +4     
  Lines              45227    45943     +716     
=================================================
+ Hits               26842    27079     +237     
- Misses             18385    18864     +479     
Files Coverage Δ
fedimint-core/src/api.rs 85.54% <100.00%> (+2.81%) ⬆️
fedimint-client/src/transaction/sm.rs 76.92% <0.00%> (-0.29%) ⬇️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elsirion
Copy link
Contributor

Can you PR to master first and then backport please (or if done already I haven't caught up yet, but the original PR should be linked here)? It's too easy to lose track otherwise.

@douglaz
Copy link
Contributor Author

douglaz commented Oct 30, 2023

Can you PR to master first and then backport please (or if done already I haven't caught up yet, but the original PR should be linked here)? It's too easy to lose track otherwise.

This was on purpose, I didn't want to include this on master/0.1 without testing it first

@justinmoon
Copy link
Contributor

Call: let's target master with this PR, first

@elsirion elsirion changed the title fix: don't limit max number of concurrent requests backport: fix: don't limit max number of concurrent requests Nov 1, 2023
@elsirion
Copy link
Contributor

elsirion commented Nov 1, 2023

Since #3497 is on master now, let's also merge this one.

@elsirion elsirion marked this pull request as ready for review November 1, 2023 17:18
@elsirion elsirion requested a review from a team as a code owner November 1, 2023 17:18
@elsirion elsirion merged commit 38a0939 into fedimint:releases/v0.1 Nov 1, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants