Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: fix: refactor gateway to avoid payments freezing state machines #3713

Merged

Conversation

elsirion
Copy link
Contributor

Fixes #3712 without the tests. @douglaz said the pure fix would be relatively easy to verify, so I did not want to resolve another huge merge conflict.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e59f0ed) 58.93% compared to head (79265d7) 58.97%.

Files Patch % Lines
gateway/ln-gateway/src/ng/pay.rs 89.70% 7 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           releases/v0.1    #3713      +/-   ##
=================================================
+ Coverage          58.93%   58.97%   +0.04%     
=================================================
  Files                214      214              
  Lines              46038    46043       +5     
=================================================
+ Hits               27131    27156      +25     
+ Misses             18907    18887      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elsirion elsirion marked this pull request as ready for review November 24, 2023 17:42
@elsirion elsirion requested a review from a team as a code owner November 24, 2023 17:42
Copy link
Contributor

@douglaz douglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elsirion elsirion merged commit 94edc84 into fedimint:releases/v0.1 Nov 24, 2023
17 of 18 checks passed
@elsirion elsirion linked an issue Nov 27, 2023 that may be closed by this pull request
@elsirion elsirion deleted the 2023-11-backport-hodl-support branch November 27, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport "Let us properly pay HOLD invoices"
2 participants