feat: improved load-test-metrics #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3717 +/- ##
==========================================
- Coverage 57.75% 57.64% -0.11%
==========================================
Files 193 193
Lines 41929 41943 +14
==========================================
- Hits 24216 24179 -37
- Misses 17713 17764 +51 ☔ View full report in Codecov by Sentry. |
elsirion
approved these changes
Nov 25, 2023
| @@ -1191,18 +1195,15 @@ async fn handle_metrics_summary( | |||
| .await?, | |||
| )) | |||
| } | |||
|
|
|||
| let mut results = HashMap::new(); | |||
| let mut results = BTreeMap::new(); | |||
There was a problem hiding this comment.
Thx! The ordering being inconsistent was quite annoying xD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gateway_payment_received_successandgateway_pay_invoice_successto detect asymmetries between receiving and sending paymentsgateway_payment_received_started_{method}togateway_{gateway_name}_payment_received_startedto make sure all the metrics use the same convention of referring to the gateway that is receiving/sending the payment