chore: suppress tx already submitted error logs #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3733 +/- ##
==========================================
- Coverage 57.74% 57.71% -0.03%
==========================================
Files 192 193 +1
Lines 41808 41976 +168
==========================================
+ Hits 24142 24228 +86
- Misses 17666 17748 +82 ☔ View full report in Codecov by Sentry. |
bradleystachurski
force-pushed
the
tx-in-block
branch
from
61739d9
to
fde641c
Compare
| // This is considered a success case, so we don't surface the error log. | ||
| // | ||
| // https://github.com/bitcoin/bitcoin/blob/daa56f7f665183bcce3df146f143be37f33c123e/src/rpc/protocol.h#L48 | ||
| Err(JsonRpc(Rpc(e))) if e.code == -27 => (), |
There was a problem hiding this comment.
2023-11-26T19:54:48.505711Z INFO fedimint_bitcoind::bitcoincore: Error broadcasting transaction error=JsonRpc(Rpc(RpcError { code: -27, message: "Transaction already in block chain", data: None }))
| // TODO: Filter `electrs` errors using codes instead of string when available in | ||
| // `electrum-client` | ||
| // https://github.com/fedimint/fedimint/issues/3731 | ||
| match error.get("message").and_then(|value| value.as_str()) { |
There was a problem hiding this comment.
2023-11-26T19:58:26.863259Z INFO fedimint_bitcoind::electrum: Error broadcasting transaction error=Protocol(Object {"code": Number(2), "message": String("Transaction already in block chain")})
| // from detecting errors for transactions already submitted. | ||
| // TODO: Suppress `esplora-client` already submitted errors when client is | ||
| // updated | ||
| // https://github.com/fedimint/fedimint/issues/3732 |
There was a problem hiding this comment.
2023-11-26T19:59:21.563877Z INFO fedimint_bitcoind::esplora: Error broadcasting transaction error=Reqwest(reqwest::Error { kind: Status(400), url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Ipv4(127.0.0.1)), port: Some(16009), path: "/tx", query: None, fragment: None } })
dpc
approved these changes
Nov 26, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3676
These changes suppress error logs returned when submitting a transaction already in a block, since this is a success case (see issue thread for more details).
We are unable to address the issue with esplora (#3732) and aren't able to handle errors with electrs as gracefully as I'd like (#3731). The associated followup issues will allow us to handle these errors gracefully across all clients but requires upstream PR merges/releases and for us to update our clients.
Relevant discussion from previous PR #2016 (comment)