Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore uncommitted dbtx writes for endpoint audits #3756

Merged
merged 1 commit into from Nov 28, 2023

Conversation

bradleystachurski
Copy link
Member

@bradleystachurski bradleystachurski commented Nov 28, 2023

Fixes #3750

Please refer to this comment for reasoning behind this approach. #3750 (comment)

Reproduced the WARN log reported in the associated issue and verified these changes no longer log a warning when running fedimint-cli --our-id 0 --password pass admin audit in mprocs.

Before

nix@lenovo-m75q:/tmp/nix-shell.yafZfU/devimint-175/logs$ rg 'DatabaseTransaction has writes and has not called commit' fedimintd-0.log
78:2023-11-28T05:23:39.844034Z  WARN db: DatabaseTransaction has writes and has not called commit. location=   0: <fedimint_core::db::CommitTracker as core::ops::drop::Drop>::drop

After

nix@lenovo-m75q:/tmp/nix-shell.yafZfU/devimint-68797/logs$ rg 'DatabaseTransaction has writes and has not called commit' fedimintd-0.log

@bradleystachurski
Copy link
Member Author

Flakey code coverage in CI. I'll keep kicking the tires tomorrow (already captured in flakey CI tracking issue).

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (681e6cc) 57.67% compared to head (7420ff3) 57.68%.
Report is 4 commits behind head on master.

Files Patch % Lines
fedimint-server/src/net/api.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3756      +/-   ##
==========================================
+ Coverage   57.67%   57.68%   +0.01%     
==========================================
  Files         193      193              
  Lines       41976    41990      +14     
==========================================
+ Hits        24208    24222      +14     
  Misses      17768    17768              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into fedimint:master with commit b45f490 Nov 28, 2023
22 checks passed
@fedimint-backports
Copy link

Successfully created backport PR for releases/v0.2:

@bradleystachurski bradleystachurski deleted the ignore-audit-writes branch November 28, 2023 14:23
@justinmoon
Copy link
Contributor

Thanks @bradleystachurski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit RPC logs logs "DatabaseTransaction has writes and has not called commit" warning
4 participants