New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve organization of ./devimint #3798
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3798 +/- ##
=======================================
Coverage 57.55% 57.55%
=======================================
Files 193 193
Lines 42173 42189 +16
=======================================
+ Hits 24272 24282 +10
- Misses 17901 17907 +6 ☔ View full report in Codecov by Sentry. |
d68d3e9
to
0a516a8
Compare
While it's a step in the right direction if you look at @mayrf Thanks for looking into it BTW. |
Yeah, and I also ran into problem with the tests. I am still not sure I get what you have in mind exactly. /tmp/devimint-.../{new_named_dir}/config If yes, do you have a naming-suggestion for the new dir? |
I don't want
|
0a516a8
to
81dd051
Compare
81dd051
to
76cad30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK, I'll leave it to @dpc to verify this is what he wanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best devimint state dir, eva.
Takes care of #3667. Title and description seem a bit contradictory, I hope interpreted it correctly.