New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): special-case descriptor for single-guardian instances #3821
feat(wallet): special-case descriptor for single-guardian instances #3821
Conversation
Using p2wpkh is more efficient than a 1-of-1 multisig
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3821 +/- ##
==========================================
+ Coverage 57.48% 57.51% +0.03%
==========================================
Files 193 193
Lines 42185 42209 +24
==========================================
+ Hits 24248 24275 +27
+ Misses 17937 17934 -3 ☔ View full report in Codecov by Sentry. |
Could also do taproot Are no changes needed for the spending? Does miniscript handle it all here? |
Yes, the beauty of descriptors and generic satisfiers! I tested it and it works, I didn't expect any problems, it's only getting easier for the satisfier.
|
Is there a single test anywhere that makes sure this works? |
I added devimint CLI tests for single guardian federations (FYI @joschisan), should have done that sooner. I think it won't slow down CI much since all these tests can run in parallel (they don't take a lot of CPU once compiling is done). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Does recovery tool need to be updated to support this? |
Capturing what we discussed in the dev call: We don't need to update the recovery tool to support, however it doesn't hurt to add a test case. |
Using p2wpkh is more efficient than a 1-of-1 multisig