fix: don't depend on std features from lightning-invoice

[elsirion]

Fixes #3837. Would be awesome if you could test this today @TonyGiorgio so we can get it into 0.2.0.

[codecov]

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (60daa84) 57.31% compared to head (0eb470e) 57.26%.

Files	Patch %	Lines
modules/fedimint-ln-common/src/lib.rs	0.00%	8 Missing ⚠️
modules/fedimint-ln-client/src/pay.rs	45.45%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3839      +/-   ##
==========================================
- Coverage   57.31%   57.26%   -0.05%     
==========================================
  Files         193      193              
  Lines       42458    42467       +9     
==========================================
- Hits        24334    24320      -14     
- Misses      18124    18147      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[justinmoon]

LGTM

[TonyGiorgio]

No, not working. Still uses is_expired() which is also being a std flag. We'll probably just edit our fork of LDK to allow some of the std flags in wasm32 that don't explicitly use SystemTime::now().

[elsirion]

Ahhh, damn it. I removed all the added calls to non-std functions, is_expired existed before, but I didn't consider that I moved it from the gateway to the client crate. So you should be able to just add that function as unimplemented! to your fork, let's figure out a way to test that we don't use std there longer term (#3838).

[TonyGiorgio]

Thanks for your help. Added a comment there. I'll try a few things out in our patch and get it working again. Thank you!

[TonyGiorgio]

Actually, you may want to pull out is_expired(), it calls SystemTime::now(). I can add unimplemented or false on our end but you'll run into this as well running the fedimint client in any wasm32 environment

        #[cfg(feature = "std")]
	pub fn is_expired(&self) -> bool {
		Self::is_expired_from_epoch(&self.timestamp(), self.expiry_time())
	}

	/// Returns whether the expiry time from the given epoch has passed.
	#[cfg(feature = "std")]
	pub(crate) fn is_expired_from_epoch(epoch: &SystemTime, expiry_time: Duration) -> bool {
		match epoch.elapsed() {
			Ok(elapsed) => elapsed > expiry_time,
			Err(_) => false,
		}
	}

    #[stable(feature = "time2", since = "1.8.0")]
    pub fn elapsed(&self) -> Result<Duration, SystemTimeError> {
        SystemTime::now().duration_since(*self)
    }

[elsirion]

Currently this is_expired fn is only called on the gateway and not the user client. But I'll fix, just not sure if worth backporting. Thx for your help in tracking this down too!