Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fedimint-cli): added support to pay a lnurl #3848

Merged
merged 1 commit into from Dec 6, 2023

Conversation

douglaz
Copy link
Contributor

@douglaz douglaz commented Dec 6, 2023

Added support to paying lnurls. Very common nowadays.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (ba94be6) 57.23% compared to head (289ec68) 57.12%.

Files Patch % Lines
fedimint-cli/src/client.rs 0.00% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3848      +/-   ##
==========================================
- Coverage   57.23%   57.12%   -0.11%     
==========================================
  Files         193      193              
  Lines       42483    42567      +84     
==========================================
+ Hits        24314    24317       +3     
- Misses      18169    18250      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@douglaz douglaz marked this pull request as ready for review December 6, 2023 03:15
@douglaz douglaz requested a review from a team as a code owner December 6, 2023 03:15
Comment on lines +506 to +508
(Some(_), Some(_)) => {
bail!("Amount specified in both invoice and command line")
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if these are equal it should be fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the invoice doesn't have an amount the recipient won't enforce it, so we'd trust the gateway to actually send the whole amount. One day the client might do the routing, then this wouldn't be a problem anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I understand that, I am saying if the user provided amount and the invoice amount are both some and equal, there's no reason to throw an error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, totally missed that, good point!

@elsirion elsirion added this pull request to the merge queue Dec 6, 2023
Merged via the queue into fedimint:master with commit d5a7bfc Dec 6, 2023
21 of 22 checks passed
@fedimint-backports
Copy link

Successfully created backport PR for releases/v0.2:

@douglaz douglaz deleted the lnurl_fedimint_cli branch December 6, 2023 15:00
@elsirion elsirion mentioned this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants