feat(fedimint-cli): added support to pay a lnurl #3848
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3848 +/- ##
==========================================
- Coverage 57.23% 57.12% -0.11%
==========================================
Files 193 193
Lines 42483 42567 +84
==========================================
+ Hits 24314 24317 +3
- Misses 18169 18250 +81 ☔ View full report in Codecov by Sentry. |
| (Some(_), Some(_)) => { | ||
| bail!("Amount specified in both invoice and command line") | ||
| } |
There was a problem hiding this comment.
if these are equal it should be fine
There was a problem hiding this comment.
If the invoice doesn't have an amount the recipient won't enforce it, so we'd trust the gateway to actually send the whole amount. One day the client might do the routing, then this wouldn't be a problem anymore.
There was a problem hiding this comment.
Yeah I understand that, I am saying if the user provided amount and the invoice amount are both some and equal, there's no reason to throw an error
There was a problem hiding this comment.
Ah, sorry, totally missed that, good point!
|
Successfully created backport PR for |
Added support to paying lnurls. Very common nowadays.