fix(gateway): allow setting configuration when disconnected

[douglaz]

Looks reasonable to me.

Closes #3852 and is a follow up of #3833

Edit: still leads to an error. Investigating it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5a7bfc) 57.21% compared to head (328383b) 57.17%.
Report is 12 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3855      +/-   ##
==========================================
- Coverage   57.21%   57.17%   -0.04%     
==========================================
  Files         193      193              
  Lines       42574    42571       -3     
==========================================
- Hits        24359    24341      -18     
- Misses      18215    18230      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TonyGiorgio]

tACk 328383b

For me it gets errors until bitcoind finishes syncing and then lnd is set up. Afterwards, it loads the gateway correctly.

docker-gatewayd-1  |  macaroon path: /lnd_data/data/chain/bitcoin/signet/admin.macaroon 
docker-gatewayd-1  | 2023-12-06T17:38:48.074881Z  INFO ln_gateway: Established HTLC stream
docker-gatewayd-1  | 2023-12-06T17:38:48.075179Z ERROR ln_gateway::lnd: Failed to establish htlc stream
docker-gatewayd-1  | 2023-12-06T17:38:48.081557Z  INFO ln_gateway: Successfully loaded Gateway clients.
docker-gatewayd-1  | 2023-12-06T17:38:48.081571Z  INFO ln_gateway: Got None while handling HTLC stream, exiting from loop...
docker-gatewayd-1  | 2023-12-06T17:38:48.081575Z  WARN ln_gateway: HTLC Stream Lightning connection broken. Gateway is disconnected
docker-gatewayd-1  | 2023-12-06T17:38:48.081581Z  INFO task: Waiting for task to finish task=LND HTLC Subscription
docker-gatewayd-1  | 2023-12-06T17:38:48.081772Z  INFO task: Task finished task=LND HTLC Subscription
docker-gatewayd-1  | 2023-12-06T17:38:48.081774Z  INFO task: Waiting for task to finish task=register clients
docker-gatewayd-1  | 2023-12-06T17:38:48.081788Z  INFO ln_gateway: register clients task received shutdown signal
docker-gatewayd-1  | 2023-12-06T17:38:48.081797Z  INFO task: Task finished task=register clients
docker-gatewayd-1  | 2023-12-06T17:38:48.081800Z ERROR ln_gateway: Disconnected from Lightning Node. Waiting 5 seconds and trying again
docker-gatewayd-1  | 2023-12-06T17:38:53.083327Z  INFO ln_gateway::lnd: Gateway configured to connect to LND LnRpcClient at 
docker-gatewayd-1  |  address: https://lnd:10009,
docker-gatewayd-1  |  tls cert path: /lnd_data/tls.cert,
docker-gatewayd-1  |  macaroon path: /lnd_data/data/chain/bitcoin/signet/admin.macaroon 
docker-gatewayd-1  | 2023-12-06T17:38:53.131924Z  INFO ln_gateway::lnd: Gateway configured to connect to LND LnRpcClient at 
docker-gatewayd-1  |  address: https://lnd:10009,
docker-gatewayd-1  |  tls cert path: /lnd_data/tls.cert,
docker-gatewayd-1  |  macaroon path: /lnd_data/data/chain/bitcoin/signet/admin.macaroon 
docker-gatewayd-1  | 2023-12-06T17:38:53.131942Z  INFO ln_gateway: Established HTLC stream
docker-gatewayd-1  | 2023-12-06T17:38:53.182521Z  INFO ln_gateway: Successfully loaded Gateway clients.

[Kodylow]

ACK, works when I run it too. @TonyGiorgio if you bump to the newer 0.17.3-beta for LND then it doesn't do the restarts

[elsirion]

@okjodom @m1sterc001guy could you take a look at this later please?

[Kodylow]

@okjodom @m1sterc001guy tagging for visibility

[okjodom]

I haven't tested new behavior, but change makes sense to me

[douglaz]

Although there are some errors, it works ¯\_(ツ)_/¯

[justinmoon]

dev call: what is the benefit of setting the network on the gateway in the first place if this will not respect it?