chore: use larger amounts in tests #3872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3872 +/- ##
=======================================
Coverage 57.17% 57.18%
=======================================
Files 193 193
Lines 42578 42578
=======================================
+ Hits 24346 24348 +2
+ Misses 18232 18230 -2 ☔ View full report in Codecov by Sentry. |
elsirion
reviewed
Dec 7, 2023
| @@ -87,7 +87,7 @@ pub async fn latency_tests(dev_fed: DevFed) -> Result<()> { | |||
| let iterations = 30; | |||
| let mut reissues = Vec::with_capacity(iterations); | |||
| for _ in 0..iterations { | |||
| let notes = cmd!(fed, "spend", "50000").out_json().await?["notes"] | |||
| let notes = cmd!(fed, "spend", "1000000").out_json().await?["notes"] | |||
There was a problem hiding this comment.
This still isn't a whole lot 😆 (1k sat)
There was a problem hiding this comment.
It has so many zeros already... :D
Maybe we need ksats(100).to_string()
elsirion
approved these changes
Dec 12, 2023
| @@ -373,8 +373,8 @@ async fn cli_tests(dev_fed: DevFed) -> Result<()> { | |||
| info!("Testing Client"); | |||
| // ## reissue e-cash | |||
| info!("Testing reissuing e-cash"); | |||
| const CLIENT_START_AMOUNT: u64 = 420000; | |||
| const CLIENT_SPEND_AMOUNT: u64 = 42; | |||
| const CLIENT_START_AMOUNT: u64 = 5_000_000_000; | |||
There was a problem hiding this comment.
This is the only change that makes the test test any amount of significance.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3866