Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change some errors to warns/infos #3885

Merged
merged 1 commit into from Dec 8, 2023

Conversation

douglaz
Copy link
Contributor

@douglaz douglaz commented Dec 8, 2023

If the error is retryable or expected to happen then we shouldn't log it as an error. Better use warn/info.

@douglaz douglaz requested review from a team as code owners December 8, 2023 19:13
@douglaz douglaz requested review from elsirion and removed request for a team December 8, 2023 19:13
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (ca4d493) 57.04% compared to head (d3022a1) 57.01%.

Files Patch % Lines
gateway/ln-gateway/src/lib.rs 20.00% 4 Missing ⚠️
modules/fedimint-ln-client/src/receive.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3885      +/-   ##
==========================================
- Coverage   57.04%   57.01%   -0.03%     
==========================================
  Files         193      193              
  Lines       42697    42699       +2     
==========================================
- Hits        24355    24344      -11     
- Misses      18342    18355      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@douglaz douglaz added this pull request to the merge queue Dec 8, 2023
Merged via the queue into fedimint:master with commit 7ac9f09 Dec 8, 2023
22 checks passed
@douglaz douglaz deleted the errors_warns_infos branch December 8, 2023 20:25
@fedimint-backports
Copy link

Successfully created backport PR for releases/v0.2:

@fedimint-backports
Copy link

Git push to origin failed for releases/v0.2 with exitcode 1

@github-actions github-actions bot mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants