Make CLI spend e-cash more configurable #3902
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3902 +/- ##
==========================================
- Coverage 57.13% 57.09% -0.04%
==========================================
Files 193 193
Lines 42861 42897 +36
==========================================
+ Hits 24487 24492 +5
- Misses 18374 18405 +31 ☔ View full report in Codecov by Sentry. |
fedimint-cli/src/client.rs
Outdated
| allow_overpay: bool, | ||
| /// After how many seconds we will try to reclaim the e-cash if it | ||
| /// hasn't been redeemed by the recipient | ||
| #[clap(long, default_value_t = 3600)] |
There was a problem hiding this comment.
thought: Is this automatic behavior? If so, isn't this a bit low for a default for something that might be passed in a DM or even piece of paper?
There was a problem hiding this comment.
Good point, what would you propose? A week?
There was a problem hiding this comment.
Sounds reasonable.
BTW. Maybe we should also eprintln! the deadline to warn/educate the user?
There was a problem hiding this comment.
could that be a warn level log? These are still shown and should be printed to stderr anyway (if not we should fix that).
There was a problem hiding this comment.
The way I think about it is: logging is for reporting what the program is doing, while (e)println for the actual output for the user. Not feeling too strongly about it one way or another.
There was a problem hiding this comment.
We need a fourth stream, stdlog! 😆
There was a problem hiding this comment.
In the CLI what would trigger this timeout path to be taken? Any other CLI command run after this timeout has passed?
There was a problem hiding this comment.
Yep, basically anything that runs the SM executor for long enough. What I like to do to trigger this manually is create a LN invoice I don't intend to pay and then await it. We might want a more general purpose "run executor" command.
elsirion
force-pushed
the
2023-12-spend
branch
from
9b6f145
to
1843a50
Compare
Previously the spend command would return the next-higher amount if the exact amount could not be represented with the available denominations.
elsirion
force-pushed
the
2023-12-spend
branch
from
1843a50
to
868f675
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Fixes #3834