chore: refactor Client initialization

[dpc]

Fix #3748

• split the 3 cases of initalization (to be built on later)
• require only needed args, instead of using Option gymnastics

[dpc]

Need to add comments and fix restore test which will now require an empty db.

[codecov]

Codecov Report

Attention: 292 lines in your changes are missing coverage. Please review.

Comparison is base (9b906d2) 57.05% compared to head (e0a081e) 57.12%.

Files	Patch %	Lines
fedimint-cli/src/lib.rs	0.00%	115 Missing ⚠️
devimint/src/federation.rs	0.00%	49 Missing ⚠️
devimint/src/main.rs	0.00%	34 Missing ⚠️
fedimint-client/src/lib.rs	75.18%	33 Missing ⚠️
fedimint-wasm-tests/src/lib.rs	0.00%	27 Missing ⚠️
fedimint-load-test-tool/src/common.rs	0.00%	21 Missing ⚠️
gateway/ln-gateway/src/client.rs	78.12%	7 Missing ⚠️
fedimint-cli/src/client.rs	0.00%	2 Missing ⚠️
fedimint-cli/src/db_locked.rs	0.00%	2 Missing ⚠️
fedimint-client/src/backup.rs	0.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3918      +/-   ##
==========================================
+ Coverage   57.05%   57.12%   +0.06%     
==========================================
  Files         193      193              
  Lines       42938    42930       -8     
==========================================
+ Hits        24499    24524      +25     
+ Misses      18439    18406      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[douglaz]

LGTM

[douglaz]

Should we backport this?

[dpc]

Added a tag, we'll see if it works and can decide then.

[fedimint-backports]

Backport failed for releases/v0.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin releases/v0.2
git worktree add -d .worktree/backport-3918-to-releases/v0.2 origin/releases/v0.2
cd .worktree/backport-3918-to-releases/v0.2
git switch --create backport-3918-to-releases/v0.2
git cherry-pick -x 3746d51dc6d060ed8a10662a2ccdd065a501160e 742c84a71410e3fb4ab5f0170580f1047c1d2f93 e0a081e9234b5d2e4a418d16c2b026414a333379