Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add span for showing operation_id in state machine transition #3921

Merged
merged 1 commit into from
Dec 12, 2023
Merged

feat: add span for showing operation_id in state machine transition #3921

merged 1 commit into from
Dec 12, 2023

Conversation

maan2003
Copy link
Member

closes #3883

@maan2003 maan2003 requested a review from a team as a code owner December 12, 2023 13:19
elsirion
elsirion previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@elsirion elsirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit

fedimint-client/src/sm/executor.rs Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e882197) 57.13% compared to head (fe7eb7e) 57.10%.

Files Patch % Lines
fedimint-client/src/sm/executor.rs 93.25% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3921      +/-   ##
==========================================
- Coverage   57.13%   57.10%   -0.03%     
==========================================
  Files         193      193              
  Lines       42861    42871      +10     
==========================================
- Hits        24487    24481       -6     
- Misses      18374    18390      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elsirion elsirion added this pull request to the merge queue Dec 12, 2023
Merged via the queue into fedimint:master with commit 83c8f51 Dec 12, 2023
20 checks passed
@fedimint-backports fedimint-backports mentioned this pull request Dec 12, 2023
Merged
@fedimint-backports
Copy link

Successfully created backport PR for releases/v0.2:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsirion elsirion elsirion approved these changes

Assignees
No one assigned
Labels
backport releases/v0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

State transitions/trigger futures should be executed inside spans
3 participants
@maan2003 @fedimint-backports @elsirion